On 6 October 2016 at 06:02, David Gibson <da...@gibson.dropbear.id.au> wrote: > On Wed, Oct 05, 2016 at 01:13:18PM -0700, Peter Maydell wrote: >> I think cpu_list_add() needs to be in init, because >> this is where we set cpu->cpu_index, and (after patch 5) >> target-arm assumes that cpu_index has been set by >> init but before realize. So I guess we should do it >> in init and then roll back in the destructor? > > That will need to be fixed on the ARM side then. The whole new > cpu_index assignment model (which allows cross-platform hotplug) > relies on it not being fixed until realize() time.
OK. I guess we need to audit all the code that can get called between init and realize, which is a bit tedious. Is there anything else we need to look for other than use of cpu_index ? thanks -- PMM
