On Fri, Oct 07, 2016 at 09:20:54AM -0500, Eric Blake wrote: > On 10/06/2016 10:53 PM, Jeff Cody wrote: > > Add checks to see if the system compiling QEMU has support for > > SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek > > data is unsupported in gluster. > > > > Note: this is not a check on whether the gluster server itself supports > > SEEK_DATA (that is already done during runtime), but rather if the > > compilation environment supports SEEK_DATA. > > > > Signed-off-by: Jeff Cody <jc...@redhat.com> > > --- > > > > Note: this patch is untested on older systems that do not support SEEK_DATA > > (e.g.. RHEL6). This won't be pulled into my tree until it is verified. > > > > CC block/gluster.o > block/gluster.c: In function ‘qemu_gluster_test_seek’: > block/gluster.c:676: warning: unused variable ‘eof’ > block/gluster.c: In function ‘find_allocation’: > block/gluster.c:1188: warning: unused variable ‘offs’ > > but compilation succeeded in spite of the warning. Would be nice to > clean that up for -Werror users. > > Tested-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> >
Thanks Eric. I'll clean that up for a v2. Jeff
