On 10/10/2016 04:22 AM, Marc-André Lureau wrote: > These 2 tests exhibit two qmp bugs fixed by the previous patches.
It looks like this is a respin because it was removed from an earlier pull request; now that the previous patches mentioned have landed and this is no longer immediately adjacent to those patches, is it worth tweaking the commit message to call out commit ids? > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Message-Id: <20160922203927.28241-4-marcandre.lur...@redhat.com> > [Rename tests/test-qemu-qmp.c to tests/qmp-test.c, cover it in > MAINTAINERS, add a file comment] > Reviewed-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com> Since you reworked the patch to get it to compile, you may want to drop the [] parenthetical inserted by Markus, as this is now a new revision of your patch (although crediting him for contributions is still appropriate). > +++ b/tests/qmp-test.c > @@ -0,0 +1,79 @@ > +/* > + * QTest testcase for QMP > + * > + * Copyright (c) 2016 Red Hat, Inc. We aren't very consistent on (C) vs. (c). I don't know if a lawyer would complain. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
