On Mon, Oct 10, 2016 at 05:11:19PM +0200, Radim Krčmář wrote:
[...]
> > But that's really a matter of taste. So:
>
> I'll currently go for an implicit else: (because 4 levels of indentation
> are getting helper-function worthy and it has less curly braces)
>
> if (!kvm_irqchip_in_kernel()) {
> error("need split irqchip");
> return false;
> }
> if (!kvm_enable_x2apic()) {
> error("enable x2apic failed");
> return false;
> }
Good to me.
>
> > Reviewed-by: Peter Xu <pet...@redhat.com>
>
> I squashed [7/8] into this patch in v5 and the second one didn't have
> your r-b, so I made the change as I'd have to drop the r-b anyway.
Sure. Thanks,
-- peterx
