On Wed, Oct 12, 2016 at 10:10 PM, Kevin Wolf <kw...@redhat.com> wrote: > Am 12.10.2016 um 18:20 hat Ashijeet Acharya geschrieben: >> On Wed, Oct 12, 2016 at 9:31 PM, Kevin Wolf <kw...@redhat.com> wrote: >> > Am 11.10.2016 um 09:37 hat Ashijeet Acharya geschrieben: >> >> This series adds blockdev-add support for SSH block driver. >> >> >> >> Patch 1 prepares the code for the addition of a new option prefix, >> >> which is "server.". This is accomplished by adding a >> >> ssh_has_filename_options_conflict() function which helps to iterate >> >> over the various options and check for conflict. >> >> >> >> Patch 2 first adds InetSocketAddress compatibility to SSH block driver >> >> and then makes it accept a InetSocketAddress under the "server" option. >> >> The old options "host" and "port" are supported as legacy options and >> >> then translated to the respective InetSocketAddress representation. >> >> >> >> Patch 3 drops the usage of "host" and "port" outside of >> >> ssh_has_filename_options_conflict() and >> >> ssh_process_legacy_socket_options() functions in order to make them >> >> legacy options completely. >> >> >> >> Patch 4 helps to allow blockdev-add support for the SSH block driver >> >> by making the SSH option available.
>> First thing I made sure if I wasn't breaking anything. Basically I >> checked if blockdev-add worked with it and then if I am able to remove >> it with x-blockdev-del. > > Did you try out all of the options that we support, including those in > InetSocketAddress? No, only 'host' and 'port' from InetSocketAddress which is why I think the tests were successful in the first place. Using other options seem to break it. Like you suggested, I think using qobject_input_visitor_new_autocast() should fix this. > >> Also, there were no major changes which could >> make the patches to break. I don't see tests available for SSH either >> so there was nothing much I can do. >> Do you have anything in mind? > > Actually, qemu-iotests has ssh support. It's probably not run very > often, so I'm not sure whether it completely passes on master, but worth > a try anyway. Check out ./check --help in tests/qemu-iotests, you'll > probably want something like './check -T -ssh'. > Oh, I wasn't aware of that. I will look around now. Thanks! > The commit message that added ssh support to the tests says: > > Note in order to run these tests on ssh, you must be running a local > ssh daemon, and that daemon must accept loopback connections, and > ssh-agent has to be set up to allow logins on the local daemon. In > other words, the following command should just work without demanding > any passphrase: > > ssh localhost > > Hope this is helpful. Yes very helpful!!! Thanks again! Ashijeet > > Kevin