On Thu, Aug 26, 2010 at 10:05:44AM +0200, Paolo Bonzini wrote: > On 08/26/2010 08:05 AM, Amit Shah wrote: > >This is what I have currently. It would need some timer handling in > >the save/load case as well, right? > > When loading you won't have any pending "info balloon" command, so I > think the timer need not be preserved across migration. > > Also, 5 seconds for a stopped guest is actually a lot, so maybe Amit's > original patch or a variant thereof would make sense anyway.
We should have a combination of both. If we know the guest is stopped we should return immediately, otherwise we should use the timer as a way to cope with a crashed/evil guest. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
