Hi Igor, On 14/10/2016 15:32, Andrew Jones wrote: > On Fri, Oct 14, 2016 at 02:42:18PM +0200, Igor Mammedov wrote: >> On Fri, 14 Oct 2016 10:54:54 +0200 >> Eric Auger <eric.au...@redhat.com> wrote: >> >>> From: Prem Mallappa <prem.malla...@broadcom.com> >>> >>> ACPI Spec 6.0 introduces IO Remapping Table Structure. This patch >>> introduces the definitions required to describe the IO relationship >>> between the PCIe root complex and the ITS. >>> >>> This conforms to: >>> "IO Remapping Table System Software on ARM Platforms", >>> Document number: ARM DEN 0049B, October 2015. >>> >>> Signed-off-by: Prem Mallappa <prem.malla...@broadcom.com> >>> Signed-off-by: Eric Auger <eric.au...@redhat.com> >> >> Preferred way to build/pack ACPI tables info is to use >> build_append_foo() functions. > > We've raised this before with Shannon, but it was already too late > for most tables. Now all tables in hw/arm/virt-acpi-build.c are > done in the style of this series, and I'd prefer we keep the style > consistent. If I ever get some free time to experiment then I might > try rewriting all of them in the build_append_ style to see how it > looks though.
Thank you for the info. Well so let's keep it as is if nobody objects. Thanks Eric > > Thanks, > drew >