On 10/14/2016 05:59 PM, Stefan Hajnoczi wrote: > On Tue, Oct 11, 2016 at 04:12:35PM +0200, Halil Pasic wrote: >> > Make raw_open for POSIX more consistent in handling errors by setting >> > the error object also when qemu_open fails. The error object was set >> > generally set in case of errors, but I guess this case was overlooked. >> > Do the same for win32. >> > >> > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> >> > Reviewed-by: Sascha Silbe <si...@linux.vnet.ibm.com> >> > Tested-by: Marc Hartmayer <mhart...@linux.vnet.ibm.com> (POSIX only) >> > >> > --- >> > >> > Stumbled upon this (POSIX) while testing VMs with too many SCSI disks in >> > respect to my nofile limit. When open hits the nofile limit while trying >> > to hotplug yet another SCSI disk via libvirt we end up with no adequate >> > error message (one stating too many files). Sadly this patch in not >> > sufficient to fix this problem because drive_new (/qemu/blockdev.c) >> > handles errors using error_report_err which is documented as not to be >> > used in QMP context. >> > >> > The win32 part was not tested, and the sole reason I touched it is >> > to not introduce unnecessary divergence. >> > >> > v4 -> v5: >> > * fix qemu-iotests by adding the filename to the message > This patch doesn't modify any iotests golden master files. Does this > mean the iotests output is unchanged? >
Exactly. Instead of modifying the golden masters I choose to modify the message generated by me and make it more verbose by appending the filename in question. Thanks for the review! Halil
signature.asc
Description: OpenPGP digital signature
