On Thu, 13 Oct 2016 15:58:55 +0200
Paolo Bonzini <pbonz...@redhat.com> wrote:

> On 12/10/2016 10:47, Stefan Hajnoczi wrote:
> > +def make_group_name(filename):
> > +    dirname = os.path.realpath(os.path.dirname(filename))
> > +    basedir = os.path.join(os.path.dirname(__file__), os.pardir)
> > +    basedir = os.path.realpath(os.path.abspath(basedir))
> > +    dirname = dirname[len(basedir) + 1:]
> > +
> > +    if dirname == "":
> > +        return "common"
> > +    return re.sub(r"/|-", "_", dirname)
> >    
> 
> The group is based on the build directory, so it includes the relative
> path from srcdir to builddir.  My build directory is weird ("+build")
> and breaks because of this.  Since the group is not really used for
> anything yet, perhaps this patch could be reverted?
> 
> Paolo
> 

As pointed out in other mails, the real problem isn't even about ending
up with weird characters in the group name, but about including the
build directory itself...

--
Greg

Reply via email to