On 19 October 2016 at 12:11, Eduardo Habkost <ehabk...@redhat.com> wrote: > BTW, if most devices aren't supposed to be used with -device, > possibly many of them don't have > cannot_instantiate_with_device_add_yet set properly.
They used to be covered by hw/core/sysbus.c setting it for them. In commit 33cd52b5d7b9adf that was removed, because under certain specialized circumstances it is now possible to dynamically add a sysbus device. If the machine model doesn't set mc->has_dynamic_sysbus they'll error out via a different route. If the machine model does set that option then it'll probably just do something unhelpful unless the user knew what they were doing. thanks -- PMM
