On Fri, Oct 21, 2016 at 05:30:39PM +0200, Pino Toscano wrote: > On Friday, 21 October 2016 13:02:21 CEST Richard W.M. Jones wrote: > > On Fri, Oct 21, 2016 at 01:16:11PM +0200, Pino Toscano wrote: > > > Rewrite the implementation of the ssh block driver to use libssh instead > > > of libssh2. The libssh library has various advantages over libssh2: > > > - easier API for authentication (for example for using ssh-agent) > > > - easier API for known_hosts handling > > > - supports newer types of keys in known_hosts > > > > > > Kerberos authentication can be enabled once the libssh bug for it [1] is > > > fixed. > > > > > > The development version of libssh (i.e. the future 0.8.x) supports > > > fsync, so reuse the build time check for this. > > > > > > [1] https://red.libssh.org/issues/242 > > > > > > Signed-off-by: Pino Toscano <ptosc...@redhat.com> > > > --- > > > > > > Changes from v1: > > > - fixed jumbo packets writing > > > - fixed missing 'err' assignment > > > - fixed commit message > > > > This version works, but I also switched from using a remote server to > > using this over localhost. > > Could you please give it a try with the remote server case as well?
I tried it and it failed with the remote server. Same kinds of errors as last time. > > It seems as if the timeout might be a bit short. Could that be made > > controllable? Or increased to match whatever libssh2 was using? > > Which timeout are you referring to? Not any particular thing, I just observed that with the remote server the errors happen quite quickly, and so perhaps there is a shorter timeout. (libssh2 apparently defaults to unlimited waiting, although I'm sure there are other timeouts in ssh or TCP which kick in).) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
