On Tue, Oct 25, 2016 at 12:12 AM, Ashijeet Acharya
<ashijeetacha...@gmail.com> wrote:
> On Mon, Oct 24, 2016 at 8:40 PM, Kevin Wolf <kw...@redhat.com> wrote:
>> Am 19.10.2016 um 14:38 hat Ashijeet Acharya geschrieben:
>>> Make NFS block driver use various fine grained runtime_opts.
>>> Set .bdrv_parse_filename() to nfs_parse_filename() and introduce two
>>> new functions nfs_parse_filename() and nfs_parse_uri() to help parsing
>>> the URI. This will help us to prepare the NFS for blockdev-add.
>>>
>>> Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com>
>>> ---
>>> block/nfs.c | 360
>>> +++++++++++++++++++++++++++++++++++++++++++-----------------
>>> 1 file changed, 261 insertions(+), 99 deletions(-)
>>>
>>> diff --git a/block/nfs.c b/block/nfs.c
>>> index 8602a44..5eb909e 100644
>>> --- a/block/nfs.c
>>> +++ b/block/nfs.c
>>> @@ -35,8 +35,12 @@
>>> + if (!uri->server || strcmp(uri->server, "") == 0) {
>>
>> No need to use strcmp(), !*uri->server is enough.
>
> Yes, fixed the same for uri->path too.
Can I ask why we do this check in SSH then?
Ashijeet
>> Kevin
