On 6 November 2016 at 17:15, Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> wrote: > v2: > - smaller commits > - improved registers comparison > - improved code style > - fixed copyright lines > > TODOs: > - improve load/store instruction generation (risugen) > - improve initial random values for FP and Vector regs (risugen) > - make write_test_code() generic (risugen)
The files risu_reginfo_ppc64le.h and ppc64.risu both still claim to be copyright Linaro Limited. Please can you confirm that I should change those to read 'Copyright (c) IBM Corp, 2016' like the other new files you have written? I've also written a trivial fix which uses 'sort keys %insn_details' rather than just 'keys %insn_details' so that the output binary remains the same if you run risugen twice with the same arguments; I then had to propagate that fix to the new places where that code got copied. It would be good to have a 'utils' module which gets used by the arch specific modules so we can avoid having duplicate functions between all the arch specific modules, but we can do that as a separate cleanup after this lot. If you give me the OK to fix up the copyright lines I can push this patchset to risu master. thanks -- PMM
