On 31.10.2016 16:38, Fam Zheng wrote: > In this way the source side QEMU is writing to the image. We need to > open it, so share-rw is required. > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > blockdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Should we make some effort to clear the flag once migration is done (i.e. via bdrv_reopen())? Also, should we set it everywhere where BDRV_O_INACTIVE is set (e.g. in postcopy migration, too)? Is it possible for these images to be opened R/W? If so, we have to make sure the source has also opened the image in shared mode, otherwise opening it will fail despite of BDRV_O_SHARE_RW. Max
signature.asc
Description: OpenPGP digital signature