Re: [Qemu-devel] [PATCH v4 42/64] tcg/arm: Handle ctz and clz opcodes

[Richard Henderson]

On 12/08/2016 09:56 AM, Alex Bennée wrote:

+        if (c && a2 == 32) {
+            tcg_out_dat_reg(s, COND_AL, INSN_CLZ, a0, 0, a1, 0);
+            break;
+        }

Why the early break instead of else leg?

+        tcg_out_dat_imm(s, COND_AL, ARITH_CMP, 0, a1, 0);
+        tcg_out_dat_reg(s, COND_NE, INSN_CLZ, a0, 0, a1, 0);
+        if (c || a0 != a2) {
+            tcg_out_dat_rIK(s, COND_EQ, ARITH_MOV, ARITH_MVN, a0, 0, a2, c);

It keeps this line under 80 columns, is all.


r~