On 15/12/16 17:04, Artyom Tarasenko wrote: > Ping? > Richard & Mark, can you please review the patches > 04, 05, 08, 10, 11,12, 14, 15, 16, 18-23 and 25-28? > > Hope I haven't missed anything from the v0 review. > > It would be nice to get it into the 2.9 release.
No objections from me on the v1, although I would like to see the official documentation updated in qemu-doc.texi perhaps with an example command line as per the cover letter (maybe a link as to where to download the PROM?) and the corrected case for Niagara. I also suspect that as you've been digging in this area a lot more than me that you're definitely going to be more of the expert here. Can you rebase your branch onto master at github so I can give it a spin and make sure there aren't any regressions? Other than that I'd like to see this merged fairly quickly if Richard is happy since my connectivity will be fairly intermittent after the next couple of weeks. ATB, Mark.
