On 09/01/2017 13:49, Markus Armbruster wrote: > Hervé Poussineau <[email protected]> writes: > >> 'ide-hd', 'ide-cd' and 'scsi-cd' devices already disable default cdrom. >> Make it the same for 'scsi-hd'. >> >> That way, we can add/replace the device on lun=2 without using -nodefaults. > > Yes, but it might upset existing usage that relies on the default > CD-ROM. In my opinion, making your needs explicit is better than > relying on defaults, but that doesn't mean we can change the defaults > unthinkingly. Definitely not qemu-trivial. > > Opinions on the change?
The original rationale for the change was "ide-hd has to suppress the default CD-ROM, or else you can't put one on secondary master without -nodefaults" but the same applies for scsi-hd vs. lun=1. So I'm not sure, but I lean towards accepting the patch. Paolo >> Signed-off-by: Hervé Poussineau <[email protected]> >> --- >> vl.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/vl.c b/vl.c >> index d77dd86..da97fe2 100644 >> --- a/vl.c >> +++ b/vl.c >> @@ -223,6 +223,7 @@ static struct { >> { .driver = "ide-hd", .flag = &default_cdrom }, >> { .driver = "ide-drive", .flag = &default_cdrom }, >> { .driver = "scsi-cd", .flag = &default_cdrom }, >> + { .driver = "scsi-hd", .flag = &default_cdrom }, >> { .driver = "virtio-serial-pci", .flag = &default_virtcon }, >> { .driver = "virtio-serial", .flag = &default_virtcon }, >> { .driver = "VGA", .flag = &default_vga }, > >
