On Thu, Jan 12, 2017 at 5:01 AM, Fam Zheng <f...@redhat.com> wrote: > On Wed, 01/11 15:51, Eric Blake wrote: >> On 01/11/2017 12:24 PM, Nir Soffer wrote: >> > From: Nir Soffer <nsof...@redhat.com> >> > >> > The result of openfile was not checked, leading to failure deep in the >> > actual command with confusing error message, and exiting with exit code 0. >> > >> > Here is one example - trying to read a pattern from an invalid chain: >> > >> > $ qemu-io -c 'read -P 1 0 1024' top.qcow2; echo $? >> >> As written, you have to guess some context about how top.qcow2 was >> created. The example can be made a bit more reproducible with: >> >> $ : > file >> $ qemu-io -f qcow2 -c ... file > > Nir, thank you for the fix. Could you also add a regression test in > tests/qemu-iotests?
Sure, will look into it. > > Reviewed-by: Fam Zheng <f...@redhat.com> > >> >> > can't open device top.qcow2: Could not open backing file: Image is not >> > in qcow2 format >> > no file open, try 'help open' >> > 0 >> > >> > With this patch, we fail earlier with exit code 1: >> > >> > $ ./qemu-io -c 'read -P 1 0 1024' top.qcow2; echo $? >> > can't open device top.qcow2: Could not open backing file: Image is not >> > in qcow2 format >> > 1 >> > >> > Signed-off-by: Nir Soffer <nir...@gmail.com> >> > --- >> > qemu-io.c | 8 ++++++-- >> > 1 file changed, 6 insertions(+), 2 deletions(-) >> >> Whether or not the commit message is improved, >> Reviewed-by: Eric Blake <ebl...@redhat.com>
