Am 17.09.2010 19:06, schrieb Anthony Liguori: > On 09/17/2010 11:18 AM, Kevin Wolf wrote: >> Note that the flush is omitted intentionally in qcow2_free_clusters. If >> anything, we can leak clusters here if we lose the writes. >> >> Signed-off-by: Kevin Wolf<kw...@redhat.com> >> > > Cluster leaking gets picked up by bdrv_check though, right? > > I think I've convinced myself that leaking clusters is not an acceptable > behavior from a security perspective but as long as it's detectable via > bdrv_check, qcow2 could implement an online check to address it.
Leaking clusters on crashes is unavoidable. But yes, qemu-img check does detect this. Kevin
