Re: [Qemu-devel] [PULL 26/36] hw/intc/arm_gicv3: Add accessors for ICH_ system registers

[Paolo Bonzini]

On 19/01/2017 15:09, Peter Maydell wrote:
> +        uint64_t lr = cs->ich_lr_el2[i];
> +
> +        if ((lr & ICH_LR_EL2_STATE_MASK) == 0 &&
> +            ((lr & ICH_LR_EL2_HW) == 1 || (lr & ICH_LR_EL2_EOI) == 0)) {

This should be "!= 0", not == 1 (reported by Coverity).

Paolo

> +            value |= (1 << i);
> +        }