Thomas Huth <th...@redhat.com> writes: > On 26.01.2017 16:09, Markus Armbruster wrote: >> Block backends defined with -drive if=ide are meant to be picked up by >> machine initialization code: a suitable frontend gets created and >> wired up automatically. >> >> if=ide drives not picked up that way can still be used with -device as >> if they had if=none, but that's unclean and best avoided. Unused ones >> produce an "Orphaned drive without device" warning. >> >> -drive parameter "if" is optional, and the default depends on the >> machine type. If a machine type doesn't specify a default, the >> default is "ide". >> >> Many machine types default to if=ide, even though they don't actually >> have an IDE controller. A future patch will change these defaults to >> something more sensible. To prepare for it, this patch makes default >> "ide" explicit for the machines that actually pick up if=ide drives: >> >> * alpha: clipper >> * arm/aarch64: spitz borzoi terrier tosa >> * i386/x86_64: generic-pc-machine (with concrete subtypes pc-q35-* >> pc-i440fx-* pc-* isapc xenfv) >> * mips64el: fulong2e > > Slightly off-topic, but: Is fulong2e still maintained? I did not spot an > entry in MAINTAINERS...?
It's covered by the general MIPS stanza: $ scripts/get_maintainer.pl -f hw/mips/mips_fulong2e.c Aurelien Jarno <aurel...@aurel32.net> (maintainer:MIPS) Yongbok Kim <yongbok....@imgtec.com> (maintainer:MIPS) qemu-devel@nongnu.org (open list:All patches CC here) >> * mips/mipsel/mips64el: malta mips >> * ppc/ppc64: mac99 g3beige prep >> * sh4/sh4eb: r2d >> * sparc64: sun4u sun4v >> >> Note that ppc64 machine powernv already sets an "ide" default >> explicitly. Its IDE controller isn't implemented, yet. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> hw/alpha/dp264.c | 1 + >> hw/arm/spitz.c | 3 +++ >> hw/arm/tosa.c | 1 + >> hw/i386/pc.c | 1 + >> hw/mips/mips_fulong2e.c | 1 + >> hw/mips/mips_malta.c | 1 + >> hw/mips/mips_r4k.c | 1 + >> hw/ppc/mac_newworld.c | 1 + >> hw/ppc/mac_oldworld.c | 1 + >> hw/ppc/prep.c | 1 + >> hw/sh4/r2d.c | 1 + >> hw/sparc64/sun4u.c | 2 ++ >> 12 files changed, 15 insertions(+) > > Patch looks right to me. > > Reviewed-by: Thomas Huth <th...@redhat.com> Thanks!