On 30.01.2017 15:12, Stefan Hajnoczi wrote: > On Thu, Jan 26, 2017 at 02:11:01PM +0100, Thomas Huth wrote: >> This patch is a port of the following commit from the Linux kernel: >> >> commit 15662b3e8644905032c2e26808401a487d4e90c1 >> Author: Joe Perches <j...@perches.com> >> Date: Mon Oct 31 17:13:12 2011 -0700 >> >> checkpatch: add a --strict check for utf-8 in commit logs >> >> Some find using utf-8 in commit logs inappropriate. >> >> Some patch commit logs contain unintended utf-8 characters when doing >> things like copy/pasting compilation output. >> >> Look for the start of any commit log by skipping initial lines that look >> like email headers and "From: " lines. >> >> Stop looking for utf-8 at the first signature line. >> >> Signed-off-by: Joe Perches <j...@perches.com> >> Suggested-by: Andrew Morton <a...@linux-foundation.org> >> Cc: Andy Whitcroft <a...@shadowen.org> >> Signed-off-by: Andrew Morton <a...@linux-foundation.org> >> Signed-off-by: Linus Torvalds <torva...@linux-foundation.org> >> >> Signed-off-by: Thomas Huth <th...@redhat.com> >> --- >> scripts/checkpatch.pl | 30 ++++++++++++++++++++++++++---- >> 1 file changed, 26 insertions(+), 4 deletions(-) > > This patch prevents including names with non-ASCII characters in the > commit description. Some people care about the proper spelling of their > names. > > Allowing UTF-8 in Signed-off-by and other headers isn't enough.
Right, and I guess the folks from the kernel checkpatch noticed this, too. That's likely why the next patch restricts this check to only happen if the patch is from a mail with non-UTF-8 content type, but still contains UTF-8 characters, i.e. there is really something fishy with the character set of the patch description. Maybe I should squash the two patches together, so that it is more obvious what is going on here? Thomas
signature.asc
Description: OpenPGP digital signature
