On 01/30/2017 01:57 AM, Alex Bennée wrote: >>> diff --git a/hw/intc/arm_gicv3_cpuif.c b/hw/intc/arm_gicv3_cpuif.c >>> index a9ee7fddf9..2624d8d909 100644 >>> --- a/hw/intc/arm_gicv3_cpuif.c >>> +++ b/hw/intc/arm_gicv3_cpuif.c >>> @@ -14,6 +14,7 @@ >>> >>> #include "qemu/osdep.h" >>> #include "qemu/bitops.h" >>> +#include "qemu/main-loop.h" >>> #include "trace.h" >>> #include "gicv3_internal.h" >>> #include "cpu.h" >>> @@ -733,6 +734,8 @@ void gicv3_cpuif_update(GICv3CPUState *cs) >>> ARMCPU *cpu = ARM_CPU(cs->cpu); >>> CPUARMState *env = &cpu->env; >>> >>> + g_assert(qemu_mutex_iothread_locked()); >>> + >> tcg_debug_assert()? > Depends if KVM can use this for emulation as well (which I think it can). >
It probably could, but it shouldn't. Let's not leak tcg_* into hw/. r~
