Hi, Your series seems to have some coding style problems. See output below for more information:
Type: series Subject: [Qemu-devel] [RFC][PATCH] qemu-img: make convert async Message-id: 1486051604-32310-1-git-send-email...@kamp.de === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 3a167eb qemu-img: make convert async === OUTPUT BEGIN === Checking PATCH 1/1: qemu-img: make convert async... ERROR: suspect code indent for conditional statements (4, 9) #118: FILE: qemu-img.c:1580: + for (i = 0; i < CONVERT_MAX_REQS; i++) { + if (s->reqs[i].sector_num == s->wr_offs && s->reqs[i].rd_completed) { ERROR: line over 90 characters #147: FILE: qemu-img.c:1609: + printf("convert_fill_read_queue req #%d @%p sector_num %ld nb_sectors %d status %d\n", i, req, elt->sector_num, elt->nb_sectors, elt->status); WARNING: line over 80 characters #149: FILE: qemu-img.c:1611: + if (elt->status == BLK_DATA || (!s->min_sparse && elt->status == BLK_ZERO)) WARNING: line over 80 characters #152: FILE: qemu-img.c:1614: + qemu_progress_print(100.0 * s->allocated_done / s->allocated_sectors, ERROR: do not use assignment in if condition #161: FILE: qemu-img.c:1623: + if ((elt = QSIMPLEQ_FIRST(&s->queue))) { ERROR: line over 90 characters #189: FILE: qemu-img.c:1650: + printf("convert_aio_read enter req %p sector_num %ld nb_sectors %d offs %ld ret %d\n", req, sector_num, nb_sectors, req->sector_offs, ret); ERROR: line over 90 characters #245: FILE: qemu-img.c:1695: + printf("convert_aio_write enter req %p sector_num %ld nb_sectors %d offs %ld ret %d\n", req, sector_num, nb_sectors, req->sector_offs, ret); ERROR: do not use C99 // comments #268: FILE: qemu-img.c:1722: + assert(0); //XXX TODO ERROR: do not use C99 // comments #311: FILE: qemu-img.c:1766: + assert(0); //XXX TODO WARNING: line over 80 characters #358: FILE: qemu-img.c:1823: + s->reqs[i].buf = blk_blockalign(s->target, s->buf_sectors * BDRV_SECTOR_SIZE); ERROR: line over 90 characters #378: FILE: qemu-img.c:1843: + printf("convert_iteration_sectors %ld n %d status %d\n", sector_num, n, s->status); ERROR: suspect code indent for conditional statements (4, 9) #452: FILE: qemu-img.c:1879: + for (i = 0; i < CONVERT_MAX_REQS; i++) { + qemu_iovec_destroy(&s->reqs[i].qiov); total: 9 errors, 3 warnings, 397 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org