On 02.02.2017 23:44, David Gibson wrote: > On Wed, Feb 01, 2017 at 11:41:40PM -0800, no-re...@patchew.org wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: [...] >> Checking PATCH 103/107: tcg/POWER9: NOOP the cp_abort instruction... >> ERROR: do not use C99 // comments >> #28: FILE: target/ppc/translate.c:6025: >> + // Do Nothing >> >> total: 1 errors, 0 warnings, 17 lines checked >> >> Your patch has style problems, please review. If any of these errors >> are false positives report them to the maintainer, see >> CHECKPATCH in MAINTAINERS. > > But this one was me being sloppy. Do we care enough to re-do the > pullreq?
We've got lot's of C++ comments in the QEMU sources already, and the CODING_STYLE document even does not mention this ... maybe this is just a left-over from the Linux kernel's checkpatch.pl script? So IMHO: Ignore this error. (and if we really agree that C++ comments are a no-go, then somebody should send a patch to update the CODING_STYLE). Thomas
signature.asc
Description: OpenPGP digital signature
