On 02/08/2017 10:04 AM, Markus Armbruster wrote: > Simple unions are simpler than flat unions in the schema, but more > complicated in C and on the QMP wire: there's extra indirection in C > and extra nesting on the wire, both pointless. They're best avoided > in new code. > > NetLegacyOptions isn't new, but it's only used internally, not in QMP. > Convert it to a flat union. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > net/net.c | 44 ++++++++++++++++++++++---------------------- > qapi-schema.json | 9 +++++++++ > 2 files changed, 31 insertions(+), 22 deletions(-) >
> +++ b/qapi-schema.json > @@ -3934,6 +3934,13 @@ > 'opts': 'NetLegacyOptions' } } > > ## > +# @NetLegacyOptionsType: > +## Same question as previous patch about a 'Since: 1.2' designation. Same end result of: Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
