On 02/09/2017 06:51 PM, Fam Zheng wrote: > On Thu, 02/09 18:13, Denis V. Lunev wrote: >> Windows reports BSOD parameters through Hyper-V crash MSRs. This >> information is very useful for initial crash analysis and thus >> it would be nice to see it in the QEMU log file. There is suitable >> log mask for the purpose. >> >> Linux guest does not provide this information, but still it would >> be nice to log that we have crashed. >> >> Changes since v1: >> - patches resplit >> - created property to query crash parameters >> - crash parameters added to panic event > This has a compiling error: > > /var/tmp/patchew-tester-tmp-fmkso1x2/src/hw/ppc/spapr_rtas.c: In function > ‘rtas_ibm_os_term’: > /var/tmp/patchew-tester-tmp-fmkso1x2/src/hw/ppc/spapr_rtas.c:337:5: error: > the address of ‘error_abort’ will always evaluate as ‘true’ [-Werror=address] > qapi_event_send_guest_panicked(GUEST_PANIC_ACTION_PAUSE, &error_abort); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > /var/tmp/patchew-tester-tmp-fmkso1x2/src/hw/ppc/spapr_rtas.c:337:5: error: > too few arguments to function ‘qapi_event_send_guest_panicked’ > In file included from > /var/tmp/patchew-tester-tmp-fmkso1x2/src/hw/ppc/spapr_rtas.c:42:0: > ../qapi-event.h:48:6: note: declared here > void qapi_event_send_guest_panicked(GuestPanicAction action, bool has_info, > GuestPanicInformation *info, Error **errp); > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > /var/tmp/patchew-tester-tmp-fmkso1x2/src/rules.mak:69: recipe for target > 'hw/ppc/spapr_rtas.o' failed > make[1]: *** [hw/ppc/spapr_rtas.o] Error 1 > Makefile:318: recipe for target 'subdir-ppc64-softmmu' failed > oops. will check other arches and resubmit. My fault.
Den
