Hi, > Clearly, for reviewing both files, I applied your patches, and then > diffed the two files created by this patch. :) > > So, what speaks against adding "-serial mon:stdio" here too? Even with a > graphical guest, the monitor is useful. And, if you care about firmware > logs (who doesn't? ;)), seeing serial output is good. (Same applies to > the guest kernel -- sooner or later everyone enables serial output for > grub2 and kernel, for reporting bugs.)
Depends on the target audience. I'd expect users don't care much, developers probably do. Yes, most of my virtual machines have a serial console too, even if they boot into graphic mode. If I screwed up graphics with a bad virtio-gpu patch it is very useful to have serial console to figure what exactly broke ... > * I'm a *huge* fan of saving disk space on the host. So, thin > provisioning FTW! Virtio-scsi is definitely a step in the right > direction, but for the disk drive, please add these wo properties: > > discard = "unmap" > werror = "enospc" Good idea! cheers, Gerd