On Sat, Feb 11, 2017 at 7:06 AM, P J P <ppan...@redhat.com> wrote: > From: Prasad J Pandit <p...@fedoraproject.org> > > In SDHCI protocol, the transfer mode register is defined > to be of 6 bits. Mask its value with '0x0037' so that an > invalid value couldn't be assigned. > > Signed-off-by: Prasad J Pandit <p...@fedoraproject.org> > --- > hw/sd/sdhci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Update: mask s->trnmod register value > -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02354.html > > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index a9c744b..0307b8c 100644 > --- a/hw/sd/sdhci.c > +++ b/hw/sd/sdhci.c > @@ -1050,7 +1050,7 @@ sdhci_write(void *opaque, hwaddr offset, uint64_t val, > unsigned size) > if (!(s->capareg & SDHC_CAN_DO_DMA)) { > value &= ~SDHC_TRNS_DMA; > } > - MASKED_WRITE(s->trnmod, mask, value); > + MASKED_WRITE(s->trnmod, mask, value & 0x0037);
This looks good. Can you use a macro for the value so then it is explained and easier to change in the future? Once you have done that: Reviewed-by: Alistair Francis <alistair.fran...@xilinx.com> Thanks, Alistair > MASKED_WRITE(s->cmdreg, mask >> 16, value >> 16); > > /* Writing to the upper byte of CMDREG triggers SD command > generation */ > -- > 2.9.3 >
