> On Feb 15, 2017, at 2:56 PM, Eric Blake <ebl...@redhat.com> wrote: > > On 02/15/2017 03:58 PM, Ben Warren wrote: > >>> >>> --- >>> tests/acpi-utils.h | 75 >>> ++++++++++++++++++++++++++++++++++++++++++++++++ >>> tests/bios-tables-test.c | 72 +--------------------------------------------- >>> 2 files changed, 76 insertions(+), 71 deletions(-) > > >>> No copyright blurb? Also, does MAINTAINERS need an update to cover the >>> new file? >>> >> Sure, I didn’t realize the header files all have copyright headers. As for >> MAINTAINERS, do you mean I should add a device entry for vmgenid? > > In this patch, you're just refactoring to a new tests/acpi-utils.h, so > I'd normally suggest adding it to the blurb that owns > tests/bios-tables-test.c - but as a pre-existing problem, that also has > no listed maintainer. we're trying to ensure that all new added files > have something listed in MAINTAINERS, even if it is in a misc section > that only emails the list, although it's harder to say what maintainer > to use for existing files that you are merely touching, and failure to > list a maintainer is not (yet) a hard failure (although there have been > patches proposed to scripts/checkpatch.pl to tighten the rules). > > A new section for vmgenid might not be a bad idea, especially it if > covers more files than just the one addition I noticed in this patch. > Thank you for clarifying. I’ll take care of it. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > —Ben
smime.p7s
Description: S/MIME cryptographic signature
