On Fri, Feb 17, 2017 at 04:42:15PM -0500, Jeff Cody wrote: > On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote: > > Hi, > > > > I am getting the following error with checkpatch.pl > > > > ERROR: externs should be avoided in .c files > > #78: FILE: block/vxhs.c:28: > > +QemuUUID qemu_uuid __attribute__ ((weak)); > > > > Is there any way to get around this, or does it mean that I would have > > to add a vxhs.h just for this one entry? > > > > I remain skeptical on the use of the qemu_uuid as a way to select the TLS > cert.
Yes, we should not be hardcoding arbitrary path lookup policies like that in QEMU. The libqnio API should allow QEMU to specify what paths it wants to use for certs directly. That allows the admin the flexibility to decide their own policy for where to put certs and the policy on which certs are used for which purpose. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|