On Tue, 02/21 15:58, Kevin Wolf wrote: > Instead of just telling that there was some conflict, we can be specific > and tell which permissions were in conflict and which way the conflict > is. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 67 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++----------- > 1 file changed, 56 insertions(+), 11 deletions(-) > > diff --git a/block.c b/block.c > index 19cf3b0..a8a2fa7 100644 > --- a/block.c > +++ b/block.c > @@ -1461,6 +1461,43 @@ static void bdrv_update_perm(BlockDriverState *bs) > bdrv_set_perm(bs, cumulative_perms, cumulative_shared_perms); > } > > +static char *bdrv_child_user(BdrvChild *c)
Poor function name IMHO, maybe bdrv_child_user_desc() or bdrv_child_owner_desc()? > +{ > + if (c->role->get_parent_desc) { > + return c->role->get_parent_desc(c); > + } > + > + return g_strdup("another user"); > +}