On 28.02.2017 13:54, Kevin Wolf wrote: > blk_new_open() is a convenience function that processes flags rather > than QDict options as a simple way to just open an image file. > > In order to keep it convenient in the future, it must automatically > request the necessary permissions. This can easily be inferred from the > flags for read and write, but we need another flag that tells us whether > to get the resize permission. > > We can't just always request it because that means that no block jobs > can run on the resulting BlockBackend (which is something that e.g. > qemu-img commit wants to do), but we also can't request it never because > most of the .bdrv_create() implementations call blk_truncate(). > > The solution is to introduce another flag that is passed by all users > that want to resize the image. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/parallels.c | 3 ++- > block/qcow.c | 3 ++- > block/qcow2.c | 6 ++++-- > block/qed.c | 3 ++- > block/sheepdog.c | 2 +- > block/vdi.c | 3 ++- > block/vhdx.c | 3 ++- > block/vmdk.c | 6 ++++-- > block/vpc.c | 3 ++- > include/block/block.h | 1 + > qemu-img.c | 2 +- > 11 files changed, 23 insertions(+), 12 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
