On 08.10.2010, at 20:06, Blue Swirl wrote: > On Fri, Oct 8, 2010 at 5:30 PM, Alexander Graf <ag...@suse.de> wrote: >> >> On 08.10.2010, at 19:28, Paolo Bonzini wrote: >> >>> On 10/07/2010 07:24 PM, Blue Swirl wrote: >>>>>> On 10/06/2010 11:32 PM, Blue Swirl wrote: >>>>>>>> >>>>>>>> @@ -91,8 +90,6 @@ static int vga_osi_call (CPUState *env) >>>>>>>> env->gpr[3] = 0; >>>>>>>> break; >>>>>>>> case 39: /* video_ctrl */ >>>>>>>> - if (env->gpr[6] == 0 || env->gpr[6] == 1) >>>>>>>> - vga_vbl_enabled = env->gpr[6]; >>>>>>>> env->gpr[3] = 0; >>>>>>>> break; >>>>>>>> case 47: >>>>>> >>>>>> NACK, this smells like an incomplete emulation. >>>> Why would we care about unfinished temporary Mac-on-Linux hack for >>>> video.x? Perhaps the correct fix is to remove vga_osi_call function >>>> and env->osi_call field entirely. >>> >>> CCing the person who could answer. >> >> I wanted to write the same thing, but canceled the mail because I wasn't >> sure if we need it. We do use video.x from MOL, don't we? >> >> Please just try to remove the whole thing altogether and see if graphics >> still work. If so, yeah, remove it :). > > OpenBIOS boots in graphical mode, I can see the penguin during Linux > boot. This is with the attached patch that removes video.x completely. > <0001-ppc-remove-video.x.patch>
Signed-off-by: Alexander Graf <ag...@suse.de> Alex
