Re: [Qemu-devel] [PATCH v2 10/21] char: useless NULL check

[Philippe Mathieu-Daudé]

On 02/27/2017 10:41 AM, Marc-André Lureau wrote:

g_strdup(NULL) returns NULL already.

Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org>

---
 chardev/char.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/chardev/char.c b/chardev/char.c
index 558fd8b31c..bb20d73fcf 100644
--- a/chardev/char.c
+++ b/chardev/char.c
@@ -764,7 +764,7 @@ void qemu_chr_parse_common(QemuOpts *opts, ChardevCommon 
*backend)
     const char *logfile = qemu_opt_get(opts, "logfile");

     backend->has_logfile = logfile != NULL;
-    backend->logfile = logfile ? g_strdup(logfile) : NULL;
+    backend->logfile = g_strdup(logfile);

     backend->has_logappend = true;
     backend->logappend = qemu_opt_get_bool(opts, "logappend", false);