> On 2 Mar 2017, at 18:08, Paolo Bonzini <pbonz...@redhat.com> wrote: > > > > On 02/03/2017 18:39, Felipe Franciosi wrote: >>> Yeah, it wasn't previously noticed since these files weren't compiled >>> by default. Since you've added make rules to enable build, I'm afraid >>> you've got the unfortunate job of cleaning up pre-existing build >>> problems. I'd suggest just doing the conversion to g_strdup_vprintf() >>> in the first patch your series. >> >> That's ok. I'll wait to see if Paolo has any other comments on v4 and then >> I'll send a v5 which includes this change. > > Just a note that this has missed 2.9 now, so I'll look at it but not > right now. :( >
Oh dang. I thought I still had a few days in March to get this sorted. :( Been super busy so couldn't send it before. Sorry for that. Appreciate you looking when you have the chance. :) Maybe I'll just send a v5 now with the extra patch to fix the build with libvhost-user. Felipe > Paolo
