On Thu, Mar 02, 2017 at 07:13:08PM +0100, Halil Pasic wrote: > Let's set the handles to the underlying facilities to their extremal > value so no accidental misuse can happen, and to make it obvious that the > notifier is dysfunctional. E.g. if we just close an fd but do not touch > the int holding the fd eventually a read/write could succeed again when > the fd gets reused, and corrupt the file addressed by the fd. > > Signed-off-by: Halil Pasic <pa...@linux.vnet.ibm.com> > --- > > No strong feelings about this, but obviously, I do think it's worth a > try. > > The one who brought this unfortunate possibility to my attention was > Michael Tsirkin. > --- > util/event_notifier-posix.c | 2 ++ > util/event_notifier-win32.c | 1 + > 2 files changed, 3 insertions(+)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature