On 10/11/10 11:03, Markus Armbruster wrote:
>
> As noted before, this is an incompatible change of the human monitor
> command: unit now defaults to 'M'. This must be noted *prominently* in
> the commit message. Best in the subject.
>
> Incompatible changes can break tools. Quick grep of libvirt:
>
> src/qemu/qemu_monitor_json.c: cmd =
> qemuMonitorJSONMakeCommand("migrate_set_speed",
> src/qemu/qemu_monitor_text.c: if (virAsprintf(&cmd, "migrate_set_speed
> %lum", bandwidth) < 0) {
>
> Looks like we're safe here.
>
> Anthony, is this incompatibility okay?
I agree it is incompatible, however it was a conscious decision to get
rid of the inconsistency we had around various places for these types of
arguments. If there is strong opposition to this change, then I can
mangle the interface to allow for the old, but IMHO bad, default of the
monitor.
> Help should be updated in the same patch; please squash 6/7 into 5/7.
Ok will do.
Cheers,
Jes
