Kevin Wolf <kw...@redhat.com> writes: > Am 02.03.2017 um 22:43 hat Markus Armbruster geschrieben: >> Errors in the pseudo-filename are all reported with the same laconic >> "Can't parse filename" message. >> >> Add real error reporting, such as: >> >> $ qemu-system-x86_64 --drive driver=sheepdog,filename=sheepdog:/// >> qemu-system-x86_64: --drive driver=sheepdog,filename=sheepdog:///: >> missing file path in URI >> $ qemu-system-x86_64 --drive driver=sheepdog,filename=sheepgod:///vdi >> qemu-system-x86_64: --drive driver=sheepdog,filename=sheepgod:///vdi: >> URI scheme must be 'sheepdog', 'sheepdog+tcp', or 'sheepdog+unix' >> $ qemu-system-x86_64 --drive >> driver=sheepdog,filename=sheepdog+unix:///vdi?socke=sheepdog.sock >> qemu-system-x86_64: --drive >> driver=sheepdog,filename=sheepdog+unix:///vdi?socke=sheepdog.sock: >> unexpected query parameters >> >> The code to translate legacy syntax to URI fails to escape URI >> meta-characters. The new error messages are misleading then. Replace >> them by the old "Can't parse filename" message. "Internal error" >> would be more honest. Anyway, no worse than before. Also add a FIXME >> comment. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > More upper/lower case inconsistency in error messages. Maybe I should > simply ignore it.
If you have a preference, I'm happy to use it for messages I touch. > Reviewed-by: Kevin Wolf <kw...@redhat.com> Thanks!
