Blue Swirl <blauwir...@gmail.com> writes: > Compiling with GCC 4.6.0 20100925 produced warnings like: > /src/qemu/hw/mips_fulong2e.c: In function 'mips_fulong2e_init': > /src/qemu/hw/mips_fulong2e.c:274:16: error: variable 'rtc_state' set > but not used [-Werror=unused-but-set-variable] > /src/qemu/hw/mips_fulong2e.c:268:16: error: variable 'isa_dev' set but > not used [-Werror=unused-but-set-variable] > /src/qemu/hw/mips_fulong2e.c:261:19: error: variable 'ram_offset' set > but not used [-Werror=unused-but-set-variable] > > Fix by removing the unused variables. > > Instead of removing, fix ram_offset use.
That part looks like a bug fix to me! Suggest to put it in its own commit, with a commit message describing its impact.
