On 03/06/2017 10:22 AM, Kevin Wolf wrote: > When adding an Error parameter, bdrv_replace_in_backing_chain() would > become nothing more than a wrapper around change_parent_backing_link(). > So make the latter public, renamed as bdrv_replace_node(), and remove > bdrv_replace_in_backing_chain(). > > Most of the callers just remove a node from the graph that they just > inserted, so they can use &error_abort, but completion of a mirror job > with 'replaces' set can actually fail. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block.c | 25 ++++++------------------- > block/mirror.c | 15 +++++++++------ > blockdev.c | 2 +- > include/block/block.h | 4 ++-- > include/block/block_int.h | 4 ++-- > 5 files changed, 20 insertions(+), 30 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
