On 03/13/2017 01:18 AM, Markus Armbruster wrote: > Common Python pitfall: 'assert base_members' fires on [] in addition > to None. Correct to 'assert base_members is not None'. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > scripts/qapi.py | 2 +- > tests/qapi-schema/union-base-empty.err | 11 +---------- > 2 files changed, 2 insertions(+), 11 deletions(-) >
> +++ b/tests/qapi-schema/union-base-empty.err > @@ -1,10 +1 @@ > -Traceback (most recent call last): > - File "tests/qapi-schema/test-qapi.py", line 56, in <module> > - schema = QAPISchema(sys.argv[1]) > - File "scripts/qapi.py", line 1483, in __init__ > - self.exprs = check_exprs(parser.exprs) > - File "scripts/qapi.py", line 917, in check_exprs > - check_union(expr, info) > - File "scripts/qapi.py", line 734, in check_union > - assert base_members > -AssertionError > +tests/qapi-schema/union-base-empty.json:5: Discriminator 'type' is not a > member of base struct 'Empty' Much nicer message. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
