On 10/12/2010 08:32 AM, malc wrote:
On Tue, 12 Oct 2010, Paolo Bonzini wrote:
On 10/12/2010 03:22 PM, malc wrote:
19 files changed, 3729 insertions(+), 456 deletions(-)
I don't think the explanation above justified net plus of 3273 lines of new
code.
The part you forgot to quote is:
Yes, failed to notice that, sorry.
Makefile | 54 +-
Makefile.dis | 6 +-
Makefile.hw | 8 +-
Makefile.objs | 4 +-
Makefile.target | 32 +-
Makefile.user | 6 +-
bsd-user/main.c | 10 +-
config.guess | 1502 ++++++++++++++++++++++++++++++++++++++
config.sub | 1731
++++++++++++++++++++++++++++++++++++++++++++
configure | 757 ++++++++++---------
create_config | 5 +-
darwin-user/machload.c | 12 +-
darwin-user/main.c | 6 +-
darwin-user/syscall.c | 2 +-
linux-user/main.c | 10 +-
pc-bios/optionrom/Makefile | 8 +-
rules.mak | 10 +-
tests/Makefile | 16 +-
tests/cris/Makefile | 6 +-
19 files changed, 3729 insertions(+), 456 deletions(-)
All these lines are in config.guess and config.sub that are shared with all
projects using Autotools and do not really need to be considered.
It's 40 lines of new code, 33 of which are in configure's help message.
I think there's a fair bit of value in looking like autoconf but a 39
patch series is a bit to digest at once.
I'll try to do a thorough review but I'd suggest keeping patch series
down to about 20 patches whenever possible and do multiple rounds as
necessary.
Regards,
Anthony Liguori
Paolo
