Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [PATCH] qemu-ga: obey LISTEN_PID when using systemd
socket activation
Message-id: 20170316161535.22157-1-pbonz...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20170315135021.6978-1-quint...@redhat.com ->
patchew/20170315135021.6978-1-quint...@redhat.com
* [new tag] patchew/20170316161535.22157-1-pbonz...@redhat.com ->
patchew/20170316161535.22157-1-pbonz...@redhat.com
Switched to a new branch 'test'
2593c43 qemu-ga: obey LISTEN_PID when using systemd socket activation
=== OUTPUT BEGIN ===
Checking PATCH 1/1: qemu-ga: obey LISTEN_PID when using systemd socket
activation...
ERROR: code indent should never use tabs
#173: FILE: qemu-nbd.c:805:
+^I/* qemu-nbd can only listen on a single socket. */$
ERROR: code indent should never use tabs
#174: FILE: qemu-nbd.c:806:
+^Iif (socket_activation > 1) {$
WARNING: line over 80 characters
#175: FILE: qemu-nbd.c:807:
+ error_report("qemu-nbd does not support socket activation with %s
> 1",
ERROR: code indent should never use tabs
#178: FILE: qemu-nbd.c:810:
+^I}$
total: 3 errors, 1 warnings, 324 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@freelists.org
