On Thu, 03/16 16:48, Ed Swierk wrote: > On Tue, Mar 14, 2017 at 8:36 AM, Fam Zheng <f...@redhat.com> wrote: > > diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c > > index e7466d3..4939f1f 100644 > > --- a/hw/scsi/virtio-scsi.c > > +++ b/hw/scsi/virtio-scsi.c > > ... > > bool virtio_scsi_handle_event_vq(VirtIOSCSI *s, VirtQueue *vq) > > { > > - virtio_scsi_acquire(s); > > if (s->events_dropped) { > > virtio_scsi_push_event(s, NULL, VIRTIO_SCSI_T_NO_EVENT, 0); > > virtio_scsi_release(s); > > Did you intend to leave this virtio_scsi_release() call?
Oops, no, we should drop it. Fam > > > return true; > > } > > - virtio_scsi_release(s); > > return false; > > }