Hi, This series seems to have some coding style problems. See output below for more information:
Message-id: 1489850003-5652-1-git-send-email-a.pereva...@samsung.com Subject: [Qemu-devel] [RFC PATCH 0/2] Calcuate downtime for postcopy live migration Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 # Useful git options git config --local diff.renamelimit 0 git config --local diff.renames True commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/1489850003-5652-1-git-send-email-a.pereva...@samsung.com -> patchew/1489850003-5652-1-git-send-email-a.pereva...@samsung.com Switched to a new branch 'test' 2bb4f0b migration: calculate downtime on dst side f39835b userfault: add pid into uffd_msg === OUTPUT BEGIN === Checking PATCH 1/2: userfault: add pid into uffd_msg... Checking PATCH 2/2: migration: calculate downtime on dst side... Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2459. Argument "m" isn't numeric in numeric eq (==) at ./scripts/checkpatch.pl line 2459. Use of uninitialized value $1 in concatenation (.) or string at ./scripts/checkpatch.pl line 2460. ERROR: braces {} are necessary for all arms of this statement #68: FILE: migration/migration.c:129: + if (a == b) [...] + else if (a > b) [...] ERROR: braces {} are necessary for all arms of this statement #70: FILE: migration/migration.c:131: + else if (a > b) [...] ERROR: unnecessary cast may hide bugs, use g_new0 instead #131: FILE: migration/migration.c:2149: + dd = (DowntimeDuration *)g_malloc0(sizeof(DowntimeDuration)); ERROR: braces {} are necessary for all arms of this statement #135: FILE: migration/migration.c:2153: + if (cpu < 0) [...] + else [...] WARNING: line over 80 characters #160: FILE: migration/migration.c:2178: + /* error_report("Could not populate downtime duration completion time \n\ ERROR: unnecessary whitespace before a quoted newline #160: FILE: migration/migration.c:2178: + /* error_report("Could not populate downtime duration completion time \n\ ERROR: Error messages should not contain newlines #160: FILE: migration/migration.c:2178: + /* error_report("Could not populate downtime duration completion time \n\ ERROR: braces {} are necessary for all arms of this statement #193: FILE: migration/migration.c:2211: + if (dd->end && dd->begin) [...] WARNING: line over 80 characters #194: FILE: migration/migration.c:2212: + trace_sumup_downtime_duration(dd->end - dd->begin, (uint64_t)key, dd->cpus); ERROR: braces {} are necessary for all arms of this statement #205: FILE: migration/migration.c:2223: + if (test_bit(cpu_iter, &dd->cpus) && dd->end && dd->begin) [...] ERROR: that open brace { should be on the previous line #222: FILE: migration/migration.c:2240: + for (i = 0; i < smp_cpus; i++) + { ERROR: braces {} are necessary even for single statement blocks #222: FILE: migration/migration.c:2240: + for (i = 0; i < smp_cpus; i++) + { + set_bit(i, &sufficient_cpus); + } ERROR: code indent should never use tabs #224: FILE: migration/migration.c:2242: +^Iset_bit(i, &sufficient_cpus);$ WARNING: line over 80 characters #262: FILE: migration/migration.c:2280: + * S2,E1 - doesn't match condition due to sequence S1,S2,E1 doesn't include CPU3, ERROR: that open brace { should be on the previous line #288: FILE: migration/migration.c:2306: + for (point_iter = 0; point_iter < smp_cpus; point_iter++) + { ERROR: braces {} are necessary even for single statement blocks #288: FILE: migration/migration.c:2306: + for (point_iter = 0; point_iter < smp_cpus; point_iter++) + { + trace_downtime_per_cpu(point_iter, downtime_cpu[point_iter]); + } ERROR: braces {} are necessary for all arms of this statement #302: FILE: migration/migration.c:2320: + if (!od->is_end || prev_od->is_end) [...] ERROR: braces {} are necessary for all arms of this statement #311: FILE: migration/migration.c:2329: + if (t_od->is_end) [...] ERROR: braces {} are necessary for all arms of this statement #367: FILE: migration/postcopy-ram.c:431: + if (strstr(line, "Name")) [...] ERROR: braces {} are necessary for all arms of this statement #369: FILE: migration/postcopy-ram.c:433: + if (strstr(line, "State")) [...] ERROR: suspect code indent for conditional statements (8, 11) #382: FILE: migration/postcopy-ram.c:446: + if (cpu_iter->thread_id == pid) + return cpu_iter->cpu_index; ERROR: braces {} are necessary for all arms of this statement #382: FILE: migration/postcopy-ram.c:446: + if (cpu_iter->thread_id == pid) [...] WARNING: line over 80 characters #414: FILE: migration/postcopy-ram.c:540: + rb_offset, msg.arg.pagefault.pid); ERROR: code indent should never use tabs #416: FILE: migration/postcopy-ram.c:542: +^Imark_postcopy_downtime_begin(msg.arg.pagefault.address,$ ERROR: code indent should never use tabs #417: FILE: migration/postcopy-ram.c:543: +^I^Idefined_mem_fault_cpu_index(msg.arg.pagefault.pid));$ ERROR: code indent should never use tabs #437: FILE: migration/savevm.c:1633: +^Itrace_loadvm_postcopy_vm_start(get_postcopy_total_downtime());$ total: 22 errors, 4 warnings, 435 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org