On 20.03.2017 12:04, Stefan Hajnoczi wrote: > On Mon, Mar 13, 2017 at 10:40:38PM +0100, Max Reitz wrote: >> This patch adds two new parameters to the preallocate() function so we >> will be able to use it not just for preallocating a new image but also >> for preallocated image growth. >> >> The offset parameter allows the caller to specify a virtual offset from >> which to start preallocating. For newly created images this is always 0, >> but for preallocating growth this will be the old image length. >> >> The new_length parameter specifies the supposed new length of the image >> (basically the "end offset" for preallocation). During image truncation, >> bdrv_getlength() will return the old image length so we cannot rely on >> its return value then. > > You documented the arguments in the commit description. Please move > them into doc comments.
Yeah, right, new_length is not really a super self-explaining name... I'll add a comment. Max
signature.asc
Description: OpenPGP digital signature
