On 03/21/2017 12:48 PM, Paolo Bonzini wrote: > Streaming or any other block job hangs when performed on a block device > that has a non-default iothread. This happens because the AioContext > is acquired twice by block_job_defer_to_main_loop_bh and then released > only once by BDRV_POLL_WHILE. (Insert rants on recursive mutexes, which > > unfortunately are a temporary but necessary evil for iothreads at the
Why the blank line? > moment). > > Luckily, the reason for the double acquisition is simple; the function > acquires the AioContext for both the job iothread and the BDS iothread, > in case the BDS iothread was changed while the job was running. It > is therefore enough to skip the second acquisition when the two > AioContexts are one and the same. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > blockjob.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > Makes sense from the description. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
