Reported to me off-list by Laurent Vivier, who found the problem while working on https://bugzilla.redhat.com/1433193; now split into https://bugzilla.redhat.com/show_bug.cgi?id=1434666. Broken since 2.7, but the fix is a one-liner (pointing out my embarrassing mistake of mis-converting a pre-decrement operator); as a bug fix, it still qualifies for 2.9 in spite of hard freeze, on the other hand, as the regression was not introduced in 2.9, I also understand if it is postponed.
v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg04072.html v2 was here: https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg04275.html Since then: - more commit message tweaks - drop a spurious hunk from the test in commit 3 Eric Blake (3): tests: Expose regression in QemuOpts visitor qom: Avoid unvisited 'id'/'qom-type' in user_creatable_add_opts qapi: Fix QemuOpts visitor regression on unvisited input qapi/opts-visitor.c | 6 +++--- qom/object_interfaces.c | 7 ++++--- tests/test-opts-visitor.c | 27 +++++++++++++++++++++++++-- 3 files changed, 32 insertions(+), 8 deletions(-) -- 2.9.3
