On 22.03.2017 17:20, Markus Armbruster wrote: > It's been a long journey, but here we are. > > The supported blockdev-add is not compatible to its experimental > predecessors; bump all Since: tags to 2.9. > > x-blockdev-remove-medium, x-blockdev-insert-medium and > x-blockdev-change need a bit more work, so leave them alone for now. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > v2: > * Another "command is considered experimental" comment dropped [Max] > * More Since: tags updated to 2.9, commit message improved, R-bys dropped
Do you want to do this recursively? There are things such as BlkdebugSetStateOptions or ReplicationMode which are only used by the corresponding BlockdevOptions*, so they too are basically only supported as of 2.9. I don't have a strong opinion, but I think I personally wouldn't bother with any of these structures and just update the tag for blockdev-add itself... You being fine with me would be enough to convince me, so: Reviewed-by: Max Reitz <mre...@redhat.com> > > blockdev.c | 4 +-- > qapi/block-core.json | 69 > ++++++++++++++++++-------------------------------- > tests/qemu-iotests/139 | 8 +++--- > tests/qemu-iotests/141 | 4 +-- > tests/qemu-iotests/147 | 2 +- > 5 files changed, 34 insertions(+), 53 deletions(-)
signature.asc
Description: OpenPGP digital signature
